This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Add new optional prop isItemAutoHighlightMatch#337
Open
bfncs wants to merge 1 commit intoreactjs:masterfrom
Open
Add new optional prop isItemAutoHighlightMatch#337bfncs wants to merge 1 commit intoreactjs:masterfrom
bfncs wants to merge 1 commit intoreactjs:masterfrom
Conversation
Author
|
Please let me know how I can help to get this merged or find a better solution. |
|
Really confused why the maintainers don't want to add this. My autocomplete results have other fields that match on them, and the top one should always get highlighted :( |
|
having a slightly different issue which also results in items not autohighlighting because of the highlighting function in the lib. this PR would help since this exposes the highlighting logic and i can just reimplement it for my own datamodel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new optional prop isItemAutoHighlightMatch that allows injecting a function to determine whether an item should be autohighlighted. The default prop implementation checks whether the value of the proposed item starts with the search value ignoring case, so there is no change in the default behaviour.
This would fix #266, #239, #310 and #239 without braking backwards compatibility or making a more involved design in the future less feasible. If this is ok, I'd gladly add some documentation, but I wanted to ask for some comments first. I think this feature is essential for advanced usage of react-autocomplete with own matching implementations.